Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should discover actuator curves as part of autotune #207

Closed
mluessi opened this issue Dec 9, 2015 · 5 comments
Closed

Should discover actuator curves as part of autotune #207

mluessi opened this issue Dec 9, 2015 · 5 comments

Comments

@mluessi
Copy link
Member

mluessi commented Dec 9, 2015

We currently have TPA, which can reduce the PID gains based on throttle. However, this is kind of a hack and should ideally be handled by autotune. I haven't studied the autotune derivation in detail, but I wonder if we can collect the throttle position during autotune (so we know the stick position for hover) and then extrapolate to determine PID gains at different throttle positions (using an optimization procedure in the GCS). We would then need some way to store this efficiently and generate gains during flight. We could use a lookup table with linear interpolation, or maybe a low order polynomial for this.

@tracernz
Copy link
Member

tracernz commented Dec 9, 2015

We can just use the (quadratic) actuator scaling to achieve this, if we could tune it automatically that would be superb.

@mluessi
Copy link
Member Author

mluessi commented Dec 9, 2015

@tracernz yes, I guess if the actuator curve fitting makes things perfectly linear, the throttle PID scaling should be linear. Unless there are some other non-linear effects..

@mlyle
Copy link
Member

mlyle commented Dec 10, 2015

@tracernz So technically the accelerometer gives us a pretty good hint about instantaneous actuator performance...

@mlyle mlyle changed the title Throttle based PID Gain Scheduling Should discover actuator curves as part of autotune Jan 15, 2016
@mlyle mlyle added this to the Post-Tanto milestone Jan 15, 2016
@mlyle mlyle modified the milestones: Quixote, Samsara Jun 12, 2016
@mlyle mlyle modified the milestones: Post-Post-Quixote, Quixote Aug 31, 2016
@ufoDziner
Copy link
Member

When this feature is implemented, it would be great if the hangtime throttle percentage was set based on the results.

@mlyle mlyle modified the milestones: Post-Neat, Neat Mar 7, 2017
@mlyle mlyle modified the milestones: Post-Wired, Wired Jul 18, 2017
@mlyle
Copy link
Member

mlyle commented Mar 13, 2018

Upon looking at the data, this isn't practical.. and we're doing way better with regards to this anyways. opening a follow-on issue-- superseded #2114

@mlyle mlyle closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants