Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max and resolution for mirror features #163

Open
edyoshikun opened this issue May 22, 2023 · 2 comments
Open

Add min/max and resolution for mirror features #163

edyoshikun opened this issue May 22, 2023 · 2 comments
Assignees
Labels
feature request New feature or request

Comments

@edyoshikun
Copy link
Contributor

I think now that we are starting to actively develop some of the tools, we should settle on what are some of the primary methods that the Mirror, Stages, Lasers, etc should models should implement.

As a start, we can implement the min and max positions and the minimum resolution (i.e. deg/radians) that the Optotune mirror can move. What do you think? @AhmetCanSolak

I have noticed some of these variables can simplify the photom code as I don't have to hardcode the variables (which are temporarily set so) but would make the code more modular if we reduce this dependency for future modification in the code.

@edyoshikun edyoshikun added the feature request New feature or request label May 22, 2023
@edyoshikun edyoshikun self-assigned this May 22, 2023
@YangLiujames
Copy link
Contributor

I agree... We can add this feature to the mirror code on copylot... I will work on it

@AhmetCanSolak
Copy link
Contributor

Sounds good! I'm totally supportive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants