-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix shared mailbox subscription bug when one user is prefix of other #5155
Open
elliefm
wants to merge
18
commits into
cyrusimap:master
Choose a base branch
from
elliefm:v311/cyr-1410-shared-subs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
force-pushed
the
v311/cyr-1410-shared-subs
branch
4 times, most recently
from
December 9, 2024 03:05
9c28409
to
9ae5781
Compare
elliefm
force-pushed
the
v311/cyr-1410-shared-subs
branch
5 times, most recently
from
December 18, 2024 00:19
b1073c8
to
aea8a0c
Compare
ksmurchison
approved these changes
Dec 18, 2024
wolfsage
reviewed
Dec 18, 2024
elliefm
force-pushed
the
v311/cyr-1410-shared-subs
branch
from
December 20, 2024 03:06
aea8a0c
to
b56690d
Compare
Even though it's just a niche bug fix, I think the sub.db version bump and autoupgrade makes this consequential enough to need a changes file |
elliefm
force-pushed
the
v311/cyr-1410-shared-subs
branch
from
December 22, 2024 23:41
b56690d
to
43996bb
Compare
wolfsage
approved these changes
Dec 23, 2024
wolfsage
requested changes
Dec 23, 2024
(with/without one user being a prefix of the other)
this will make testing with domains a lot easier
since these are only used for the subscriptions database! If we ever want to version mailboxes.db (as the old name implied), it'd need its own number anyway.
elliefm
force-pushed
the
v311/cyr-1410-shared-subs
branch
from
December 26, 2024 23:04
43996bb
to
bb951f4
Compare
wolfsage
approved these changes
Dec 27, 2024
@rsto I think you're doing the FM builds next week, so FYI I've tagged this include-in-fastmail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: I'd suggest stepping through this one commit by commit
\Nonexistent
flag if youLSUB
orLIST (SUBSCRIBED) ...
them.