Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't count filtered tests as "OK" in report #81

Open
elliefm opened this issue Sep 23, 2019 · 1 comment
Open

don't count filtered tests as "OK" in report #81

elliefm opened this issue Sep 23, 2019 · 1 comment

Comments

@elliefm
Copy link
Contributor

elliefm commented Sep 23, 2019

$./testrunner.pl ClamAV
Cyrus::ClamAV.aaasetup                                                  [  OK  ]
Cyrus::ClamAV.notify_deleted                                            [  OK  ]
Cyrus::ClamAV.custom_notify_deleted                                     [  OK  ]

Time:  0 wallclock secs ( 0.01 usr  0.01 sys +  0.31 cusr  0.12 csys =  0.45 CPU)

OK (4 tests)

In this case ClamAV.remove_infected_slow was skipped due to a filter, but the report at the end still counts it toward those "4 tests"

@elliefm
Copy link
Contributor Author

elliefm commented Sep 23, 2019

I think this is just inherent to the way Cassandane blurs the line between what's a test and what's a suite. Test::Unit::Result increments the run_count when the test is started, and Test::Unit::TestSuite doesn't start tests that match the filter, but:

# The 'run' method makes this class look sufficiently like a
# Test::Unit::TestCase that Test::Unit::TestRunner will happily run it.
# This enables us to run all our scheduled tests with a single
# TestResult and a single summary of errors.

Uh oh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant