Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add Codecov? #97

Open
joydeep049 opened this issue Jan 2, 2025 · 4 comments
Open

Should we add Codecov? #97

joydeep049 opened this issue Jan 2, 2025 · 4 comments
Labels
discussion Community talk on a given topic

Comments

@joydeep049
Copy link
Contributor

A lot of the existing code doesn't have proper documentation yet.
Adding docstrings to functions and classes would improve the readability to a great extent, and adding codecov to check docstring coverage would be the appropriate way to start emphasizing proper documentation.

cc @cyclotruc

@filipchristiansen
Copy link
Collaborator

@joydeep049

  • I have added docstrings to all functions, classes, and modules in this PR, and enforced docstring existence using darglint as part of our CI pipeline (and pre-commit hooks). However, I didn’t enforce docstrings for the test functions yet.
  • I’m not sure if Codecov can directly check for docstring coverage, but it makes sense to integrate it once we have a solid testing setup. We could upload the pytest test report to Codecov to track it.
  • I suggested to @cyclotruc to add Codecov for test coverage, but he preferred to wait until we have more structured tests in place, as the current ones are not fully structured yet. However, I agree that Codecov should be added at some point.

@joydeep049
Copy link
Contributor Author

For docstring coverage check, we can add interrogate to our CI. That would require every file to have atleast 80% docstring coverage for the CI to pass.

@cyclotruc
Copy link
Owner

For docstring coverage check, we can add interrogate to our CI. That would require every file to have atleast 80% docstring coverage for the CI to pass.

It sounds too strict for now, I think those rules should come progressively as the repo gets more complex

@joydeep049
Copy link
Contributor Author

joydeep049 commented Jan 3, 2025

For docstring coverage check, we can add interrogate to our CI. That would require every file to have atleast 80% docstring coverage for the CI to pass.

It sounds too strict for now, I think those rules should come progressively as the repo gets more complex

I agree. Putting it in the CI might be too strict for now. We can advise contributors to run interrogate locally to make sure they have decent coverage.

@cyclotruc

@cyclotruc cyclotruc added the discussion Community talk on a given topic label Jan 4, 2025
@filipchristiansen filipchristiansen changed the title discussion: should we add codecov Should we add Codecov? Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Community talk on a given topic
Projects
None yet
Development

No branches or pull requests

3 participants