Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

injest url field isn't case insensitive. #110

Closed
jadedgnome opened this issue Jan 7, 2025 · 3 comments · Fixed by #115
Closed

injest url field isn't case insensitive. #110

jadedgnome opened this issue Jan 7, 2025 · 3 comments · Fixed by #115

Comments

@jadedgnome
Copy link

type Https://... with a uppercasee h on mobile and there was a repo not found error.
@filipchristiansen filipchristiansen self-assigned this Jan 8, 2025
@filipchristiansen
Copy link
Collaborator

type Https://... with a uppercasee h on mobile and there was a repo not found error.

Thank you for pointing this out! I appreciate you taking the time to report the issue. I'll work on making the URL field case insensitive to fix the problem. Stay tuned for the update!

@filipchristiansen filipchristiansen added the work in progress This PR is not ready yet but is being worked on label Jan 8, 2025
filipchristiansen added a commit to filipchristiansen/gitingest that referenced this issue Jan 8, 2025
@filipchristiansen
fix(parse_query): make URL handling case insensitive
8c0d80b 
- Convert `source` to lowercase in `parse_query`
- Add `test_parse_query_mixed_case` to verify functionality

Resolves cyclotruc#110
@filipchristiansen filipchristiansen mentioned this issue Jan 8, 2025
Merged
@filipchristiansen
Copy link
Collaborator

Hi there @jadedgnome,

Thanks again for reporting this! I've addressed the problem by making the URL field case insensitive in the parse_query function and added a corresponding test to ensure it works with mixed-case URLs. You can follow the progress and review the changes in this pull request that resolves this issue.

This fix should resolve the "repo not found" error caused by uppercase letters in the URL. Thanks for your patience, and feel free to let me know if you encounter any further issues!

@jadedgnome
Copy link
Author

thanks for responding so quickly and resolving it!

@filipchristiansen filipchristiansen removed the work in progress This PR is not ready yet but is being worked on label Jan 10, 2025
@filipchristiansen filipchristiansen removed their assignment Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make ingest URL field case insensitive in parse_query filipchristiansen/gitingest
2 participants
@jadedgnome @filipchristiansen