fix:(#371) Device Port if default then not set is displayed #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-cvit
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Hey @tanbirali, you are changing the resource namespace here, but you should default to not set if the port name is missing in the table here.
|
My bad I got it wrong, will revert it and make the necessary changes |
|
Have a look now, if this is what you wanted
|
…t then not setis to be rendered
petar-cvit
reviewed
Jun 28, 2024
There was a problem hiding this comment.
@tanbirali Can we also set the not set to be gray so its clear that its not provided? Here is an example of how we did it on another place
|
Closing this one, since #384 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #371
📑 Description
checks if namespace is default if default then not set is displayed
✅ Checks
ℹ Additional context