Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Service Port Name #371

Closed
KaradzaJuraj opened this issue Jun 25, 2024 · 1 comment
Closed

Default Service Port Name #371

KaradzaJuraj opened this issue Jun 25, 2024 · 1 comment
Assignees
@tanbirali
Labels
good first issue Good for newcomers react typescript UI Update on the UI

Comments

@KaradzaJuraj
Copy link
Collaborator

KaradzaJuraj commented Jun 25, 2024 •
edited
Loading

Problem

It is legitimate for a service port to have no value in its name. We should implement a default so that it is not empty when deployed to Cyclops.
Screenshot 2024-06-23 at 15 53 08

Solution

When a service port has no name, the default display should be <not set> You can test it out with the redis-demo template
@KaradzaJuraj KaradzaJuraj added good first issue Good for newcomers UI Update on the UI typescript react labels Jun 25, 2024
@KaradzaJuraj KaradzaJuraj changed the title Default Service Name Default Service Port Name Jun 25, 2024
@tanbirali
Copy link
Contributor

I will like to work on this

tanbirali added a commit to tanbirali/cyclops that referenced this issue Jun 28, 2024
@tanbirali
fix:(cyclops-ui#371) Device Port if default then not set is displayed
d122b57
@tanbirali tanbirali mentioned this issue Jun 28, 2024
Closed
1 task
tanbirali added a commit to tanbirali/cyclops that referenced this issue Jun 28, 2024
@tanbirali
fix:(cyclops-ui#371) Device Port if default then not set is displayed
1c12a62
tanbirali added a commit to tanbirali/cyclops that referenced this issue Jun 28, 2024
@tanbirali
fix:(cyclops-ui#371) console log removed and name index if not presen…
b99fa57 
…t then not setis to be rendered
tanbirali added a commit to tanbirali/cyclops that referenced this issue Jun 29, 2024
@tanbirali
fix:(cyclops-ui#371) text for <not set> changed to gray
e1ffa55
tanbirali added a commit to tanbirali/cyclops that referenced this issue Jun 29, 2024
@tanbirali
fix:(cyclops-ui#371) Namespace is added in the Module Header
43ee306
petar-cvit pushed a commit that referenced this issue Jun 29, 2024
@tanbirali
🫙 default when no service port name (#384)
0f00daf 
* fix:(#371) Device Port if default then not set is displayed

* fix:(#371) Device Port if default then not set is displayed

* fix:(#371) console log removed and name index if not present then not setis to be rendered

* fix:(#371) text for <not set> changed to gray

* fix:(#371) Namespace is added in the Module Header
petar-cvit pushed a commit that referenced this issue Jul 5, 2024
@tanbirali
❎ fix:(#368) Removed the third unnecessary status (#392)
365c0fa 
* fix:(#371) Device Port if default then not set is displayed

* fix:(#371) Device Port if default then not set is displayed

* fix:(#371) console log removed and name index if not present then not setis to be rendered

* fix:(#371) text for <not set> changed to gray

* fix:(#371) Namespace is added in the Module Header

* fix:(#368) Removed the third unnecessary status

* fix:(#368) Removed the calculation unnecessary status icon
petar-cvit pushed a commit that referenced this issue Jul 19, 2024
@tanbirali
🔗 link to template (#448)
a69ebe7 
* fix:(#371) Device Port if default then not set is displayed

* fix:(#371) Device Port if default then not set is displayed

* fix:(#371) console log removed and name index if not present then not setis to be rendered

* fix:(#371) text for <not set> changed to gray

* fix:(#371) Namespace is added in the Module Header

* fix:(#368) Removed the third unnecessary status

* fix:(#368) Removed the calculation unnecessary status icon

* A function added and link to the template attached

* CSS added for hover effect

* If TemplateRefLocked then gray color is applied and on hover underline is applied

* The hex color #B8B8B8 is used and the css class created for underline effect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanbirali tanbirali

Labels
good first issue Good for newcomers react typescript UI Update on the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix:(#371) Device Port if default then not set is displayed tanbirali/cyclops
3 participants
@petar-cvit @KaradzaJuraj @tanbirali