Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Deployment logs #341

Open
petar-cvit opened this issue Jun 16, 2024 · 16 comments · May be fixed by #618
Open

Filter Deployment logs #341

petar-cvit opened this issue Jun 16, 2024 · 16 comments · May be fixed by #618
Assignees
Labels
good first issue Good for newcomers ⚔️ Quest Tracks quest-bot quests UI Update on the UI

Comments

@petar-cvit
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Cyclops shows logs for running pods here. Scope of the task is to add a search for logs that you can use to filter out the log you are looking for.

Describe the solution you'd like
Add a search bar to the top of the logs modal and show all logs that contain the search input.

@petar-cvit petar-cvit added good first issue Good for newcomers UI Update on the UI labels Jun 16, 2024
@doncicuto
Copy link
Contributor

Hi @petar-cvit would the search box that comes with React Ace would fit your need?

image

@petar-cvit
Copy link
Collaborator Author

@doncicuto Actually yeah, I actually searched for something out of the box like this, but didn't find it. Exactly what we need. Could you open a PR for it?

@doncicuto
Copy link
Contributor

Perfect @petar-cvit you can assign the issue to me then and do you want the Search button to show for every React Ace editor or just for the one for Deployment logs?

@petar-cvit
Copy link
Collaborator Author

Just the one with the logs will do

@petar-cvit
Copy link
Collaborator Author

Hey @doncicuto, do you have any updates on the issue?

@doncicuto
Copy link
Contributor

Next week I'll prepare a PR, sorry for the delay, busy summer!

Copy link

quest-bot bot commented Oct 6, 2024

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #341 to link your PR to this Quest.

Questions? Check out the docs.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 6, 2024
@Sheikh-Abubaker
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Oct 6, 2024

@Sheikh-Abubaker has embarked on their Quest. 🗡

  • @Sheikh-Abubaker has been on GitHub since 2022.
  • They have merged 37 public PRs in that time.
  • Their swords are blessed with Shell and Smarty magic ✨
  • They have contributed to this repo before.

Questions? Check out the docs.

@Sheikh-Abubaker
Copy link
Contributor

@petar-cvit I'm taking this one!

@Sheikh-Abubaker
Copy link
Contributor

Sheikh-Abubaker commented Oct 6, 2024

Hey @petar-cvit a lot has changed since you opened this issue, could you please let me know where this deployment code is located at, the reference you mentioned in the description aren't there any more in the main.

Update: Found out the podlogs code

@Sheikh-Abubaker
Copy link
Contributor

Would something like this do the job @petar-cvit ? I just tested it locally.

2024-10-07.05-46-29.mp4

@petar-cvit
Copy link
Collaborator Author

@Sheikh-Abubaker thanks! Can you check if we can implement something similar to #341 (comment) since it looks more clean in the UI and seems like it supports regex and casing in the search?

@Sheikh-Abubaker Sheikh-Abubaker linked a pull request Oct 7, 2024 that will close this issue
2 tasks
@Sheikh-Abubaker
Copy link
Contributor

@quest-bot loot #341

Copy link

quest-bot bot commented Oct 7, 2024

⚠️ Oops... You can only loot in a Pull Request!

Check the docs for more info.

Copy link

quest-bot bot commented Oct 7, 2024

🧚 @Sheikh-Abubaker has submitted PR #618 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ⚔️ Quest Tracks quest-bot quests UI Update on the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants