-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to edit or delete module if you use a bad repo path #336
Comments
@skunklabz sorry for the delayed response. We have revamped the flow and removed the details button, and now the whole module card is clickable and will show you the module details page. However, if you create a module with a bad repo URL, if you click directly on it, it will still take you to the page not found. We should disable the link if its a valid address. Here is the code for the link rendering that needs fixing. The issue is not as severe is as it was, but we should still fix it. |
hi @petar-cvit i would love to work on this issue, can you please assign this to me? |
Hey @s-vamshi, sure |
@petar-cvit here are the things i have noticed,
|
Hey @s-vamshi
|
hi @petar-cvit , |
So if the repo is valid and you have a resolvedVersion the link as follows should work:
You can check if the link is valid if it starts with |
Describe the bug
Unable to view the details of a module that was created using a bad repo path. You are just given a "Page not found :/" error and no option to edit or delete the module.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I'm expecting to be able to view the details of all modules, regardless of whether or not they have a bad repo URL, or path. Instead I'm given a simple 'Page not found :/' and no option to do anything else.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: