Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the "List*" for "Get*" to follow the same convention #76

Open
xescugc opened this issue Apr 18, 2019 · 2 comments
Open

Modify the "List*" for "Get*" to follow the same convention #76

xescugc opened this issue Apr 18, 2019 · 2 comments
Labels
Provider: AWS Issues related to the AWS Provider

Comments

@xescugc
Copy link
Member

xescugc commented Apr 18, 2019

We have 2 methods ListBuckets and ListObjects that should use Get* instead of List* as all the other methods use the Get*.

@xlr-8
Copy link
Contributor

xlr-8 commented Apr 19, 2019

The convention was done, to reuse the naming of AWS, each of them have various List/Get methods:
https://docs.aws.amazon.com/sdk-for-go/api/service/s3/#S3.ListBuckets
https://docs.aws.amazon.com/sdk-for-go/api/service/s3/ (various GetBucketX)

Or for objects:
https://docs.aws.amazon.com/sdk-for-go/api/service/s3/#S3.ListObjects
https://docs.aws.amazon.com/sdk-for-go/api/service/s3/#S3.GetObject (plus many GetObjectX function too)

But I guess that your point is about the plural form of the calls: ObjectS and BucketS, is it correct?

@xescugc
Copy link
Member Author

xescugc commented Apr 23, 2019

My point is also that we already have List aws methods using the Get on out API, so for that I would say to use the Get as it's the one we use on most of them.

Same for the Describe we do use the Get and not Describe.

@xescugc xescugc transferred this issue from cycloidio/raws Dec 18, 2019
@xescugc xescugc added the Provider: AWS Issues related to the AWS Provider label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Provider: AWS Issues related to the AWS Provider
Projects
None yet
Development

No branches or pull requests

2 participants