Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of line breaks in auto-generated API documents #406

Open
4 tasks
masa213f opened this issue Apr 25, 2022 · 1 comment
Open
4 tasks

Lack of line breaks in auto-generated API documents #406

masa213f opened this issue Apr 25, 2022 · 1 comment

Comments

@masa213f
Copy link
Contributor

masa213f commented Apr 25, 2022

What

The API documents are not rendor as we expected.

  • Blank lines in comments are converted to \n\n.
  • Bullet points don't have a trailing newline.

(1) Structure Description

Source comment

https://github.com/cybozu-go/moco/blob/v0.12.0/api/v1beta1/backuppolicy_types.go#L11-L24

// BackupPolicySpec defines the configuration items for MySQLCluster backup.[ymmt, 11 months ago: • Add API resources for backup and restore](https://sourcegraph.com/github.com/cybozu-go/moco/-/commit/250860ff212b56d22335e76851b09dea7a62037a)
//
// The following fields will be copied to CronJob.spec:
//
// - Schedule
// - StartingDeadlineSeconds
// - ConcurrencyPolicy
// - SuccessfulJobsHistoryLimitYusuke Suzuki, 10 months ago: • Add History Limit to BackupPolicySpec
// - FailedJobsHistoryLimit
//
// The following fields will be copied to CronJob.spec.jobTemplate.
//
// - ActiveDeadlineSeconds
// - BackoffLimit
generated document

https://github.com/cybozu-go/moco/blob/v0.12.0/docs/crd_backuppolicy_v1beta1.md#backuppolicyspec

BackupPolicySpec defines the configuration items for MySQLCluster backup.\n\nThe following fields will be copied to CronJob.spec:\n\n- Schedule - StartingDeadlineSeconds - ConcurrencyPolicy - SuccessfulJobsHistoryLimit - FailedJobsHistoryLimit\n\nThe following fields will be copied to CronJob.spec.jobTemplate.\n\n- ActiveDeadlineSeconds - BackoffLimit

(2) Field Description

Source comment

https://github.com/cybozu-go/moco/blob/v0.12.0/api/v1beta2/mysqlcluster_types.go#L56-L63

	// Collectors is the list of collector flag names of mysqld_exporter.
	// If this field is not empty, MOCO adds mysqld_exporter as a sidecar to collect
	// and export mysqld metrics in Prometheus format.
	//
	// See https://github.com/prometheus/mysqld_exporter/blob/master/README.md#collector-flags for flag names.
	//
	// Example: ["engine_innodb_status", "info_schema.innodb_metrics"]
	// +optional
generated document

https://github.com/cybozu-go/moco/blob/v0.12.0/docs/crd_mysqlcluster_v1beta2.md#mysqlclusterspec

Collectors is the list of collector flag names of mysqld_exporter. If this field is not empty, MOCO adds mysqld_exporter as a sidecar to collect and export mysqld metrics in Prometheus format.\n\nSee https://github.com/prometheus/mysqld_exporter/blob/master/README.md#collector-flags for flag names.\n\nExample: ["engine_innodb_status", "info_schema.innodb_metrics"]

How

Describe how to address the issue.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@masa213f
Copy link
Contributor Author

I contacted the author of the tool.
clamoriniere/crd-to-markdown#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant