Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add register-month and retire-month labels #663

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

zoetrope
Copy link
Member

@zoetrope zoetrope commented Sep 8, 2023

Add registration and retiring months to node labels.
These labels will be helpful in scheduling pods.

@zoetrope zoetrope self-assigned this Sep 8, 2023
Comment on lines 55 to 56
n.Labels["cke.cybozu.com/retire-date"] = m.Spec.RetireDate.Format("2006-01")
n.Labels["cke.cybozu.com/register-date"] = m.Spec.RegisterDate.Format("2006-01")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a month rather than a date.

@zoetrope zoetrope force-pushed the register-retire-date-label branch from 472ae42 to b9ab8b7 Compare September 8, 2023 10:46
@zoetrope zoetrope changed the title Add register-date and retire-date labels Add register-month and retire-month labels Sep 8, 2023
@zoetrope zoetrope marked this pull request as ready for review September 8, 2023 11:24
@zoetrope zoetrope requested a review from zeroalphat September 12, 2023 05:30
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope merged commit 6708bda into main Sep 12, 2023
6 checks passed
@zoetrope zoetrope deleted the register-retire-date-label branch September 12, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants