Fix cke_node_reboot_status metrics
#660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoetrope
force-pushed
the
fix-node-metrics
branch
4 times, most recently
from
fb07a25 to
8b23c08
Compare
morimoto-cybozu
requested changes
Sep 7, 2023
zoetrope
force-pushed
the
fix-node-metrics
branch
from
8b23c08 to
be22819
Compare
morimoto-cybozu
requested changes
Sep 11, 2023
Co-authored-by: morimoto-cybozu <[email protected]>
morimoto-cybozu
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an issue with
cke_node_reboot_statusmetrics not being reflected correctly in the following cases:This PR calculates the value of metrics each time they are collected.
As a result we will be able to get correct metrics.