Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider writing a setup script and get py2exe working #3

Open
cyberkitsune opened this issue Aug 31, 2022 · 7 comments
Open

Consider writing a setup script and get py2exe working #3

cyberkitsune opened this issue Aug 31, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@cyberkitsune
Copy link
Owner

Compiling out an actual exe for both VRCSubs and VRCNowPlaying may be nice, making it so people won't have to install python / click the add to PATH checkbox.

@cyberkitsune cyberkitsune added the enhancement New feature or request label Aug 31, 2022
@cyberkitsune cyberkitsune self-assigned this Aug 31, 2022
@senkodev
Copy link
Contributor

senkodev commented Sep 3, 2022

Why not PyInstaller? It's much easier to implement in my opinion

@MaxFerney
Copy link

I've used cx_Freeze to make python executables about 5 years ago, Not sure if it's still good for it, but it makes pretty neatly packaged executables and is not too hard to setup.

@KuryKat
Copy link

KuryKat commented Mar 22, 2023

To be honest it is a good idea but at the same time people have been very against using """random""" .exe (after all Discord scams)

So it might be hard at first to convince people that it is safe, since said scams were also python codes... and people are judgy with python, sadly

@cyberkitsune
Copy link
Owner Author

To be honest it is a good idea but at the same time people have been very against using """random""" .exe (after all Discord scams)

Yeah this has been one of the main blockers to this, doubly so when a lot of malicious software does get wrapped with stuff like py2exe and trips up antivirus stuff all the time.

I'm still considering it though, as python installation issues are 90% of the support requests I get. I may not move to this until I can sign exes though...

@blankochan
Copy link

Here's another potential solution, i thought I'd weigh in with, bundle the repository with the start.bat's and have those instead of launching python from path, launch from a virtual env skipping all the downloading and also preventing things from breaking when a package updates, I'm on my phone and can't test if this would work but i see no reason why it wouldn't because virtual envs or at least everyone I've created all have their own bundled python binaries, and any Linux users almost certainly know how to install a requirements.py if we just leave it there

@blankochan
Copy link

So after much pain and research, ive discovered 2 things I hate git and it does everything in its power to make uploading a venv hell and venvs do not work across computers.
Yes I made sure it wasn't in git ignore

@cyberkitsune
Copy link
Owner Author

Yeah I don't think shipping a venv would be wise, they're not quite designed for distribution. I think some python to executable wrapper will be the best way to go about this. I'll mess around and evaluate a few of them and see what works best ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants