Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How best to add a feature (image overlays) #738

Open
titaniumbones opened this issue Mar 30, 2016 · 1 comment
Open

How best to add a feature (image overlays) #738

titaniumbones opened this issue Mar 30, 2016 · 1 comment

Comments

@titaniumbones
Copy link

I've just started to work on a custom-geo-mashup that adds the ability to use image overlays. It is very primitive and not at all integrated into the Wordpress workflow.

I've been thinking about it and it seems like a feature that might be of more general use. What would I need to do/learn in order to submit a proper patch request?

the few lines of horrible relevant code are all in custom.js at:

https://github.com/titaniumbones/geo-mashup-custom

It's a bit embarrassing to show at this point...

@cyberhobo
Copy link
Owner

Glad you're having fun hacking with geo mashup! The Mapstraction library at least has a method for image overlays. That project seems to have died unfortunately, but I'd at least see how good the existing support is and maybe make needed improvements to geo mashup's bundled version. That would be a good initial contribution, then a shortcode option could be built on top of it.

Note that there is already a shortcode parameter to load a KML URL.

I did some work a few years ago for the Visible Past project, that might be of interest, though I think it just uses KML attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants