Skip to content

Conversation

@xavi-999
Copy link

@xavi-999 xavi-999 commented Nov 20, 2025

Summary

Adds CioFirebaseWrapper dependency to customerio-reactnative-richpush.podspec which is used by the Notification Service Extension and FCM consumers.

In the setup push notifications guide, CioFirebaseWrapper was being imported inadvertently, the dependency was not present on the .podspec that is used by the Extension.

Screenshot 2025-11-20 at 13 39 13

In the 4x -> 5.0.0 migration guide, it is also indicated that:
Check imports: Ensure you’ve added import CioFirebaseWrapper to all files that import CioMessagingPushFCM -> the Notification Service is one of them.

In order to comply with the setup/troubleshoot guide and to ensure that the user does not have any build errors, the .podspec now includes the CioFirebaseWrapper dependency.

Changes

Added CioFirebaseWrapper dependency to customerio-reactnative-richpush.podspec under FCM.
Added CioFirebaseWrapper import to the Notification Service of the sample iOS app.


Note

Adds CioFirebaseWrapper to the FCM rich push podspec and imports it in the sample Notification Service for FCM builds.

  • Podspec (customerio-reactnative-richpush.podspec):
    • FCM subspec: add dependency CioFirebaseWrapper using package["cioiOSFirebaseWrapperSdkVersion"].
  • Example iOS app:
    • example/ios/NotificationServiceExtension/NotificationService.swift: when USE_FCM, add import CioFirebaseWrapper.

Written by Cursor Bugbot for commit 1f52114. This will update automatically on new commits. Configure here.

@xavi-999 xavi-999 requested a review from a team as a code owner November 20, 2025 13:47
Copy link
Contributor

@mahmoud-elmorabea mahmoud-elmorabea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xavi-999

Thank you so much for trying to help out with this change!

Can you please expand on why you believe this is needed? CioFirebaseWrapper is only needed for the main SDK and for token handling. NSE target only handles richp push and tracking metrics and does not need this dependency.

@xavi-999
Copy link
Author

Hey @mahmoud-elmorabea , thanks for your answer.

As described in the PR description, the import CioFirebaseWrapper is present in the NSE for the push setup guidelines for FCM/ObjC, which in turn led to the supposition that it may have some usage from the NSE.

image

Is this a mistake in the setup guidelines code? Consumers who have FCM/ObjC and try to setup pushes while copy pasting the sample code will always run into the error of CioFirebaseWrapper not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants