Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run the sidecar logic if a settings tab is open #9

Open
phillco opened this issue Oct 1, 2022 · 0 comments
Open

Don't run the sidecar logic if a settings tab is open #9

phillco opened this issue Oct 1, 2022 · 0 comments

Comments

@phillco
Copy link
Member

phillco commented Oct 1, 2022

Most of the time you'd want to disable the sidecar logic via the feature flag is when you're trying to change a setting. We should just check if any open tabs are settings related if we can, and skip the closing of those tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant