Skip to content

Make neovim deploy more robust #2584

@pokey

Description

@pokey
Member

Today, neovim deploy assumes that any changes to the staging dir come from the head commit. But if there is a race and two commits come in at nearly the same time due to merge queue, we could attribute the changes to the wrong commit

With cursorless-talon it works well because we use a subtree split, but we can't do that here because deploy is not simply a subtree: we actually build something

I'm not sure exactly the best way to do this. One way would be to keep a staging branch of some sort similar to how we do for cursorless-talon, and then re-build and create the staging directory for every commit between last deployed and head. I still think this might result in a race. We should really try to ensure determinism: the commit history on monorepo main completely determines the commit history on deploy branch

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    app-neovimIssues related to neovim support

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pokey

        Issue actions

          Make neovim deploy more robust · Issue #2584 · cursorless-dev/cursorless