Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFTP tests fail on OpenBSD (ci/GHA) #13623

Open
vszakats opened this issue May 13, 2024 · 5 comments
Open

TFTP tests fail on OpenBSD (ci/GHA) #13623

vszakats opened this issue May 13, 2024 · 5 comments
Labels

Comments

@vszakats
Copy link
Member

vszakats commented May 13, 2024

I did this

While adding an OpenBSD job (with tests) to GHA, some tests failed to run:

The common pattern is that they are TFTP related. Failures are consistent,
but not completely: 1009 and 1049 are on and off.

It seems actual output contains the expected content twice:
#13583 (comment)

I expected the following

Expected these tests to pass. (They do on NetBSD and OmniOS added at the same time.)

curl/libcurl version

master

operating system

OpenBSD 7.5

@bagder bagder added the TFTP label May 13, 2024
@bagder
Copy link
Member

bagder commented May 13, 2024

It probably requires that someone debugs this on an OpenBSD box...

@vszakats
Copy link
Member Author

It looks as if TFTP requests were executed twice:

   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                  Dload  Upload   Total   Spent    Left  Speed
 
   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 100    41    0    41    0     0  50679      0 --:--:-- --:--:-- --:--:-- 50679
 
 100    41    0    41    0     0  45253      0 --:--:-- --:--:-- --:--:-- 45253

Is there any place to look for clues?

@vszakats vszakats changed the title TFTP tests consistently fail on OpenBSD TFTP tests fail on OpenBSD May 13, 2024
@bagder
Copy link
Member

bagder commented May 14, 2024

Is tftp_do actually called twice?

@vszakats
Copy link
Member Author

tftp_do() is only called once:

=== Start of file stderr271
   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                  Dload  Upload   Total   Spent    Left  Speed
 
   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0DEBUG: tftp_do() begin
 DEBUG: tftp_do() end result:|0| done:|0|
 
 100    36    0    36    0     0  28548      0 --:--:-- --:--:-- --:--:-- 28548
 
 100    36    0    36    0     0  26607      0 --:--:-- --:--:-- --:--:-- 26607
=== End of file stderr271

Ref: https://github.com/curl/curl/actions/runs/9076301772/job/24938697525#step:3:3515
Using this patch for tracing: 6db4aee

@vszakats

This comment was marked as outdated.

@vszakats vszakats changed the title TFTP tests fail on OpenBSD TFTP tests fail on OpenBSD (ci/GHA) May 15, 2024
vszakats added a commit that referenced this issue May 19, 2024
Add these jobs to GHA:
- NetBSD, cmake-unity, clang, OpenSSL, x86_64, with tests, w/o python,
  no parallelism (was flaky sometimes)
- OpenBSD, cmake-unity, clang, LibreSSL, x86_64, with tests,
  with python, -j8, TFTP results ignored due to #13623.
- FreeBSD, cmake-unity and autotools, clang, OpenSSL, arm64
  (Tests disabled for arm64, because they are slow. It's available for
  x86_64 with python, -j12.)
  Configuration matches our existing Cirrus CI one.
- OmniOS, autotools, gcc, OpenSSL, x86_64, with tests, -j12.

All build with websockets and examples.

Closes #13583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants