-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace groovy script with FreeMarker template engine #2669
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2669 +/- ##
=========================================
Coverage 84.68% 84.68%
+ Complexity 2682 2680 -2
=========================================
Files 322 322
Lines 9449 9450 +1
Branches 899 899
=========================================
+ Hits 8002 8003 +1
Misses 1120 1120
Partials 327 327
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! But it didn't work on my machine because of relative paths. I guess. I've pushed some fixes for that to the cucumber-java
part.
Also put the code gen code into src/codegen/java
instead. This is then compiled to target/codegen-classes
to avoid packaging the code gen code in the jar build with mvn package
.
For now lets polish cucumber-java
that before we copy it over to cucumber-java8
. It would be good to keep in mind that this will be copied over. You can do this by extracting all the configuration constants to the top of the file and/or program arguments.
🤔 What's changed?
Replace groovy scripts with FreeMarker templates to generate code.
⚡️ What's your motivation?
Fixes #2648
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.