Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of CommonJS dependencies for Angular client library #8871

Open
mauriciocirelli opened this issue Oct 28, 2024 · 0 comments
Open

Get rid of CommonJS dependencies for Angular client library #8871

mauriciocirelli opened this issue Oct 28, 2024 · 0 comments
Labels
client:ngx Issues relating to the Angular client SDK enhancement New feature proposal

Comments

@mauriciocirelli
Copy link

Dear,

I am working with Angular 17 and cube-client libraries.
When building the project, I get this warning on cube client v1.0.0:

Warning: ...\node_modules\@cubejs-client\ngx\dist\fesm2015\cubejs-client-ngx.js depends on 'fast-deep-equal'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
@igorlukanin igorlukanin added enhancement New feature proposal client:ngx Issues relating to the Angular client SDK labels Nov 1, 2024
@igorlukanin igorlukanin changed the title Warning on Angular 17 packages Get rid of CommonJS dependencies for Angular client library Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client:ngx Issues relating to the Angular client SDK enhancement New feature proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauriciocirelli @igorlukanin