cras_topic_tools: Little fixes suggested by linters.

Author: peci1

cras_topic_tools/include/cras_topic_tools/priority_mux_base.h

@@ -107,6 +107,8 @@ class PriorityMux : public ::cras::HasLogger
               const SetTimerFn& setTimerFn, const ::ros::Time& now, const ::cras::LogHelperPtr& log,
               const ::std::string& noneTopic = "__none", int nonePriority = 0);
 
+  virtual ~PriorityMux();
+
   /**
    * \brief Callback function run when input topic message is received.
    *

cras_topic_tools/include/cras_topic_tools/repeat.h

@@ -111,7 +111,7 @@ class RepeatMessagesNodelet : public ::cras::Nodelet
   /**
    * \brief Reset the repeater, e.g. after a time jump.
    */
-  void reset();
+  void reset() override;
 
   /**
    * \brief Record the incoming message if it passes validations, and publish it if `publishOnlyOnTimer` is false.

cras_topic_tools/include/cras_topic_tools/throttle_messages.h

@@ -95,7 +95,7 @@ class ThrottleMessagesNodelet : public ::cras::Nodelet
   /**
    * \brief Reset the rate limiter, e.g. after a time jump.
    */
-  void reset();
+  void reset() override;
 
   /**
    * \brief Publish the incoming message if the rate limiter allows.

cras_topic_tools/src/generic_lazy_pubsub.cpp

@@ -37,8 +37,8 @@ cras::GenericLazyPubSub::GenericLazyPubSub(
   const size_t inQueueSize, const size_t outQueueSize, CallbackType callback,
   ros::SubscribeOptions subscribeOptions, const cras::LogHelperPtr& logHelper) :
     cras::ConditionalSubscriber(cras::bind_front(&cras::GenericLazyPubSub::subscribe, this), logHelper),
-    topicIn(topicIn), topicOut(topicOut), callback(std::move(callback)), subscribeOptions(std::move(subscribeOptions)),
-    inQueueSize(inQueueSize), outQueueSize(outQueueSize), nhIn(nhIn), nhOut(nhOut)
+    topicIn(topicIn), topicOut(topicOut), inQueueSize(inQueueSize), outQueueSize(outQueueSize),
+    nhIn(nhIn), nhOut(nhOut), callback(std::move(callback)), subscribeOptions(std::move(subscribeOptions))
 {
   // We have to connect at the beginning so that we can create the publisher from a subscribed message.
   std::lock_guard<std::mutex> lock(this->connectMutex);
@@ -105,7 +105,7 @@ ros::AdvertiseOptions cras::GenericLazyPubSub::createAdvertiseOptions(
   opts.has_header = cras::hasHeader(*msg);
   if (event.getConnectionHeaderPtr() != nullptr)
   {
-    const auto header = event.getConnectionHeader();
+    const auto& header = event.getConnectionHeader();
     opts.latch = header.find("latching") != header.end() && event.getConnectionHeader()["latching"] == "1";
   }
   return opts;

cras_topic_tools/src/priority_mux_base.cpp

@@ -23,7 +23,7 @@ PriorityMux::PriorityMux(const std::unordered_map<std::string, cras::priority_mu
                          const cras::PriorityMux::SetTimerFn& setTimerFn, const ::ros::Time& now,
                          const cras::LogHelperPtr& log, const std::string& noneTopic, int nonePriority) :
   cras::HasLogger(log), topicConfigs(topicConfigs), lockConfigs(lockConfigs), setTimer(setTimerFn),
-  noneTopic(noneTopic), nonePriority(nonePriority)
+  noneTopic(noneTopic), nonePriority(nonePriority), lastActivePriority(nonePriority)
 {
   this->resetImpl(now);
 
@@ -40,6 +40,8 @@ PriorityMux::PriorityMux(const std::unordered_map<std::string, cras::priority_mu
   }
 }
 
+PriorityMux::~PriorityMux() = default;
+
 bool PriorityMux::cb(const std::string& inTopic, const ros::Time& stamp, const ros::Time& now)
 {
   const auto it = this->topicConfigs.find(inTopic);

cras_topic_tools/src/repeat.cpp

@@ -105,6 +105,8 @@ void RepeatMessagesNodelet::onReset(const ros::MessageEvent<const topic_tools::S
 
 void RepeatMessagesNodelet::reset()
 {
+  NodeletWithSharedTfBuffer::reset();
+
   this->timer.setPeriod(this->rate->expectedCycleTime(), true);
 
   std::lock_guard<std::mutex> lock(this->msgMutex);

cras_topic_tools/src/throttle_messages.cpp

@@ -110,6 +110,7 @@ void ThrottleMessagesNodelet::onReset(const ros::MessageEvent<const topic_tools:
 
 void ThrottleMessagesNodelet::reset()
 {
+  NodeletWithSharedTfBuffer::reset();
   std::lock_guard<std::mutex> lock(this->limiterMutex);
   this->limiter->reset();
 }