Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization Code Flow with Client Secret #3

Open
MartinLoeper opened this issue Dec 5, 2024 · 3 comments
Open

Authorization Code Flow with Client Secret #3

MartinLoeper opened this issue Dec 5, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MartinLoeper
Copy link

First of all, thanks @ctron for this wonderful tool. I want to quickly outline my usecase for oidc-cli and discuss one limitation I encoutered.

Usecase
I use oidc-cli to obtain an access token from Keycloak. Then, I swap the token for an AccessToken using MinIOs STS.

I noticed that MinIO requires its OIDC clients to be confidential, i.e. use a client secret. It supports the Authorization Code Flow and the Client Credentials Flow (aka Service Account Roles in Keycloak).

The latter one works with oidc-cli, but does not make much sense, since I want the end user to authenticate itself and not the OIDC client.

Issue
Is there a particular reason why the client types in oidc-cli are named "confidential" and "public" instead of using the OIDC flow names?
What I need in the MinIO usecase described above, is a confidential client (i.e. a client sending its client secret) via Authorization Code Flow.
I think this is not the typical usecase, but should be supported by the OIDC spec.

What do you think?

@ctron
Copy link
Owner

ctron commented Dec 6, 2024

Is there a particular reason why the client types in oidc-cli are named "confidential" and "public" instead of using the OIDC flow names?

Yes and no. It saw the use of this in certain locations, and it felt simpler to understand from an end user perspective. Not ideal, and it can be improved for sure!

What do you think?

I think it's a perfectly valid use case. Having a PR for this would be wonderful. And we can definitely think about the name confidential (or others). Naming is hard, but it feels like the cherry on top if everything else.

@ctron ctron added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 6, 2024
@MartinLoeper
Copy link
Author

Thanks for the feedback @ctron! Makes sense to me. I will give it a shot once I get some time to study Rust a bit. I do not know when I'll have time though.

@ctron
Copy link
Owner

ctron commented Dec 6, 2024

Same here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants