Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review, Please #45

Open
ctesta01 opened this issue Jun 1, 2017 · 0 comments
Open

Code Review, Please #45

ctesta01 opened this issue Jun 1, 2017 · 0 comments

Comments

@ctesta01
Copy link
Owner

ctesta01 commented Jun 1, 2017

Please Review My Documentation and Code

I would like to ask that if you have some amount of time you could invest in the QualtricsTools project that you help me review some of the documentation, code, or guides that I have written.
I am including a sample of suggested material that I would love some feedback on. Please pick a single item, or a couple if you'd like, and let me know how I could improve them.

Specific questions you might keep in mind:

  • Does the documentation explain why you might need that function/parameter/item?
  • Do you understand why we need the function, code, logic, or web-app-component that you're reviewing?
  • Do you see relevant functionalities that are not explained/mentioned somewhere they should be?
  • Is the code clear, readable, concise, etc?

Extra bonus points:

  • Could the code be written such that it runs faster?
  • Can the code be simplified/improved/reduced?

Documentation:

Easier:

Harder:

Code:

Easier (Still Subtle, though):

Harder:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant