Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy to Insight: Pluralize orig_header_row -> orig_header_rows #36

Open
ctesta01 opened this issue Nov 29, 2016 · 0 comments
Open

Legacy to Insight: Pluralize orig_header_row -> orig_header_rows #36

ctesta01 opened this issue Nov 29, 2016 · 0 comments

Comments

@ctesta01
Copy link
Owner

ctesta01 commented Nov 29, 2016

This doesn't necessarily need to be done, it would just be nice style.

When I was originally writing code for Legacy, there was only one extra header row in the CSV data. Therefore, when I stripped it out from the CSV response data, I called it the "original header row" or some variant of that. Now, with "Qualtrics Insights," there are three headerrows and so this pluralization should be reflected in the codebase. However, I think that because I only had to transition from handling a 2xN to 3xN dataframe, and there was no change of data structure in that update, that the problem is mostly aesthetic.

@ctesta01 ctesta01 changed the title orig_header_row -> orig_header_rows Legacy to Insight: Pluralize orig_header_row -> orig_header_rows May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant