You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
It may become tedious to constantly call window.puppeteerCommand(...). We could implement helper functions for common commands such as screenshot, goto etc.
My main concern is with this is that it may be confusing for people that only certain functions are exposed.
Thoughts @charlieduong94?
The text was updated successfully, but these errors were encountered:
Exposing a few helper functions would be nice to have. I'm in favor of possibly deprecating window.puppeteerCommand (or maybe marking it as unsafe) and exposing only a small subset of commands. Commands such as goto can be harmful since it causes the current page to redirect, thus causing the test suite to stop.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It may become tedious to constantly call
window.puppeteerCommand(...)
. We could implement helper functions for common commands such asscreenshot
,goto
etc.My main concern is with this is that it may be confusing for people that only certain functions are exposed.
Thoughts @charlieduong94?
The text was updated successfully, but these errors were encountered: