Skip to content
This repository has been archived by the owner on Aug 6, 2023. It is now read-only.

Consider creating helper functions for common puppeteer commands #40

Open
austinkelleher opened this issue Oct 31, 2017 · 1 comment
Open

Comments

@austinkelleher
Copy link
Collaborator

It may become tedious to constantly call window.puppeteerCommand(...). We could implement helper functions for common commands such as screenshot, goto etc.

My main concern is with this is that it may be confusing for people that only certain functions are exposed.

Thoughts @charlieduong94?

@ctdio
Copy link
Owner

ctdio commented Oct 31, 2017

Exposing a few helper functions would be nice to have. I'm in favor of possibly deprecating window.puppeteerCommand (or maybe marking it as unsafe) and exposing only a small subset of commands. Commands such as goto can be harmful since it causes the current page to redirect, thus causing the test suite to stop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants