Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination, Search, CSS for Business Donation History Table Resolved #48

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Pagination, Search, CSS for Business Donation History Table Resolved #48

merged 5 commits into from
Mar 6, 2024

Conversation

benson-fm
Copy link
Collaborator

Resolves #41

gdavid7
gdavid7 reviewed Mar 2, 2024
View reviewed changes
Copy link
Contributor

@gdavid7 gdavid7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but code can be more concise. Nice job!

src/components/BusinessDonationHistory/BusinessDonationHistory.jsx Outdated Show resolved Hide resolved
src/components/BusinessDonationHistory/BusinessDonationHistory.jsx Outdated Show resolved Hide resolved
src/components/BusinessDonationHistory/BusinessDonationHistory.jsx Outdated Show resolved Hide resolved
src/components/BusinessDonationHistory/BusinessDonationHistory.jsx Outdated Show resolved Hide resolved
Madhu2244
Madhu2244 requested changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Madhu2244 Madhu2244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is working which is great to see, however, we need the frontend to look identical to the figma. Please add CSS (as much through Chakra as possible), and then using the BusinessDonationHistory.module.css to finish it up.

@Madhu2244
Copy link
Member

Please change these dates so that they match the Figma.
image

@Madhu2244
Copy link
Member

For CSS, reference this PR: #49 and just look at src/components/DonationTrackingTable/DonationTrackingTable.module.css and src/components/DonationTrackingTable/DonationTrackingTable.jsx to see how the CSS was created and imported.

As for the fonts you dont have to worry about it, it will all get merged in at the end as well as the scroll bar.

@Madhu2244 Madhu2244 merged commit 752e9be into main Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctc-devops ctc-devops ctc-devops left review comments

@gdavid7 gdavid7 gdavid7 left review comments

@Madhu2244 Madhu2244 Madhu2244 requested changes

@joshualipton joshualipton Awaiting requested review from joshualipton

Assignees

@benson-fm benson-fm

@kevnlliu kevnlliu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination, Search, CSS for Business Donation History Table
5 participants
@benson-fm @Madhu2244 @gdavid7 @ctc-devops @kevnlliu