Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sanitizer options directly #107

Open
lzaoral opened this issue Jun 1, 2023 · 1 comment
Open

Set sanitizer options directly #107

lzaoral opened this issue Jun 1, 2023 · 1 comment
Labels

Comments

@lzaoral
Copy link
Member

lzaoral commented Jun 1, 2023

util-linux has the following line in its test-suite:

https://github.com/util-linux/util-linux/blob/90b12595bbe3357fdbccf5eec6c3885e53bc614e/tests/functions.sh#L302

Thus, it will override any setting (e.g. log collection) csmock has set. We can use csexec to make sure the environment will be set correctly.

@lzaoral lzaoral self-assigned this Jun 1, 2023
@lzaoral lzaoral added the bug label Jun 1, 2023
@lzaoral lzaoral changed the title Do not set sanitizer options directly Set sanitizer options directly Jun 1, 2023
@kdudka
Copy link
Member

kdudka commented Jun 5, 2023

Sounds like a good idea. We will still have a problem if someone executes the test-suite in a sanitized environment (obtained e.g. by env -i ...) because it will wipe our configuration for csexec.

@lzaoral lzaoral removed their assignment Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants