Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspect-ratio should support both auto and <ratio> in combination #293

Closed
ryo-manba opened this issue Oct 17, 2024 · 2 comments
Closed

aspect-ratio should support both auto and <ratio> in combination #293

ryo-manba opened this issue Oct 17, 2024 · 2 comments

Comments

@ryo-manba
Copy link

In the CSS Tree syntax docs it is defined as auto | <ratio>, but the correct syntax should be auto || <ratio>.

The following syntax should function as a fallback, but it currently raises a warning.

aspect-ratio: auto 3/4;
aspect-ratio: 9/6 auto;

Related issue: stylelint/stylelint#8027
@ryo-manba ryo-manba changed the title Incorrect aspect-ratio Syntax Definition aspect-ratio should support both auto and <ratio> in combination Oct 17, 2024
@ryo-manba ryo-manba mentioned this issue Oct 17, 2024
Closed
@ryo-manba ryo-manba mentioned this issue Oct 28, 2024
Merged
@ryo-manba
Copy link
Author

I've submitted a PR to upstream, which should resolve this issue.

@ryo-manba ryo-manba mentioned this issue Oct 28, 2024
Closed
@ryo-manba
Copy link
Author

Resolved in this commit.
4175e97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryo-manba and others