Use memoize-one package #1358
Closed
Use memoize-one package #1358
+22
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate the care, but I don't care enough about this to merge this compared to the risk breaking something and having another dependency. I can change my mind once there is a strong reason. |
|
No worries. I was just looking through issues and saw it as a simple task
and thought I could do it to help out. Might as well close the issue though
eh?
…On Sun, 28 Jun 2020 at 22:13, Oleg Isonen ***@***.***> wrote:
I appreciate the care, but I don't care enough about this to merge this
compared to the risk breaking something and having another dependency. I
can change my mind once there is a strong reason.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1358 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABWCZOPOCD3FS5X4DUZ6D3RY4JTRANCNFSM4OJYWDZQ>
.
|
|
I am keeping them so that people don't create new once) |
|
If you want something to work on, I am happy to find you high prio issues |
|
Cheers. Please do
…On Sun, 28 Jun 2020 at 22:25, Oleg Isonen ***@***.***> wrote:
If you want something to work on, I am happy to find you high prio issues
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1358 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABWCZLYZOB4QWLDCRVIA2DRY4LDHANCNFSM4OJYWDZQ>
.
|
|
I created this #1359, let's see if its a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue (if exists):
#1127
What would you like to add/fix?
Use memoize-one package instead of custom implementation