Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support csscomb.js #4

Open
tonyganch opened this issue Nov 6, 2013 · 3 comments
Open

Support csscomb.js #4

tonyganch opened this issue Nov 6, 2013 · 3 comments

Comments

@tonyganch
Copy link
Member

We have a node version of csscomb ready.
It will be nice if this mixin is updated by the time of public release.

If someone starts working on this task, please leave a comment.
Keep in mind that current (php) version should stay available for download.
The easiest way is to make a release before making any changes.
Thank you.

@drudge
Copy link
Member

drudge commented Nov 9, 2013

@tonyganch: I've updated the mixin to use the csscomb node module. This has been pushed as v2.0.0 and is live in Chocolat's "Install Mixin" menu.

@drudge drudge closed this as completed Nov 9, 2013
@tonyganch tonyganch reopened this Nov 9, 2013
@tonyganch
Copy link
Member Author

@drudge, I don't like the idea of storing node_modules, the whole csscomb.js repo and all its dependencies in this plugin.
And I'm sad that it's published already.
Can we please discuss this?

@tonyganch
Copy link
Member Author

@drudge, first of all, the plugin is broken now.
Have you tested it?
You can not use csscomb like this: new Comb().processString(text).
There should be a config file.
Default one is .csscomb.json in the root of the module.
So code should like this:

var comb = new Comb(),
    config = require(pathToConfig);
comb.configure(config);
comb.processString(text);

Secondly, csscomb's module should be removed from this repo.
There are at least two ways to include it:

  1. Ask users to run npm install csscomb -g and then require the global module inside your plugin.
  2. Require npm module inside your plugin, run npm install csscomb (either with spawn/exec, or with npm.load()) and then use the local module.
    The second one is preferred if there is no problem with write permissions.

Please, can you unpublish this broken version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants