Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with next version of ggplot2 #20

Open
thomasp85 opened this issue Oct 10, 2022 · 2 comments
Open

Issues with next version of ggplot2 #20

thomasp85 opened this issue Oct 10, 2022 · 2 comments

Comments

@thomasp85
Copy link

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that your package somehow includes references to ggplot2 code from when it was build, either by reloading saved plot objects or by grabbing functions at build time. Please see https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/ for some more info about why this can cause issues.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/[email protected]') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards
Thomas

@BramVDBe
Copy link

@csdaw @actions-user Is this a critical thing? I would be sad to see ggprism outdated for future ggplot versions.

@csdaw
Copy link
Owner

csdaw commented Nov 2, 2022

Thanks for the bump!

The guide_prism functions currently rely on some non-exported functions from ggplot2 which is not advisable. I'll try and fix this similar to teunbrand/ggh4x@ddd2a36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants