-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization of the predictor types #52
Comments
Yeah, I think you're right. How about this:
Oh, and we'll need type parameters on these, I just left it open to get a quick start |
For consistency, can we name the last one |
Oops, yes that's what I meant :) |
The parts of this that are blocking 0.1.0 are implemented in #91. There is still additional work to be done, but it doesn't block 0.1.0. |
I'm now second-guessing whether we really need a |
I'm going to mark this as potentially breaking, since it will probably result in some changes to the return types of public functions. |
Currently, we only have a single predictor type:
I think we'll need a slightly more complicated set of types.
For
predict_joint
, we will continue to useSossMLJPredictor
. But forpredict
, I think we'll need different types.For
predict
with a classification model, we'll need to useMLJBase.UnivariateFinite
for compliance with the MLJ model interface.For
predict
with a regression model, it's not immediately obvious to me what we should return.The text was updated successfully, but these errors were encountered: