CS50P week 7 "Working 9 to 5": staff version accepts invalid format

[Richard-B-UK]

"In a file called working.py, implement a function called convert that expects a str in either of the 12-hour formats below...

9:00 AM to 5:00 PM
9 AM to 5 PM"

In test_working.py, I tested various invalid formats including "09 AM to 09 PM", intending to raise a ValueError; but this test caused the staff version to fail (ie, the staff version of working.py accepts this format).

[niktss]

Experiencing the same issue with my test

with pytest.raises(ValueError):
        convert("009:00 AM to 012 PM")

[bxngyn]

Thanks for your comment!

I agree that the check should be stricter, as the assignment instruction specifically states the four 12-hour formats the program should accept. I have opened PR #328 for this issue, which will be reviewed soon.