Skip to content

Python Shirt tests don't accurately test command line args #153

Open
@curiouskiwi

Description

@curiouskiwi

For each of the command line checks, we are looking for a non-zero exit code, but that will happen if the program crashes with an IndexError when it tries to access argv[1] or argv[2] for example, or with a PIL.UnidentifiedImageError if it tries to open a non-suitable image file.

Our checks currently can't distinguish between a purposeful sys.exit("invalid usage") and one of those errors. Hence green smiles even if the code does not check for such things.

@CarterZenke related to: #196

Metadata

Metadata

Labels

CS50PCS50 Python

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions