Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate javascript files to typescript #8

Open
yufengwng opened this issue Apr 13, 2022 · 2 comments
Open

Migrate javascript files to typescript #8

yufengwng opened this issue Apr 13, 2022 · 2 comments

Comments

@yufengwng
Copy link
Collaborator

TypeScript and JavaScript can co-exist, but for sake of development we should probably just stick to one thing. TypeScript has a number of benefits, and vscode extensions are typically written in typescript. Convert all the js files we have to ts.
@yufengwng yufengwng mentioned this issue Apr 13, 2022
Open
@yufengwng
Copy link
Collaborator Author

This is not strictly necessary, just a nice-to-have. It'll be a lot of effort though. Can be a low-priority.

@yufengwng
Copy link
Collaborator Author

As part of #19, the webpack config has been updated to support typescript, so we can use typescript code in the javascript code. This way, we can gradually migrate the javascript to typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yufengwng