Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Candidate]: #8

Open
emrsrb opened this issue Jul 18, 2023 · 1 comment
Open

[Bug-Candidate]: #8

emrsrb opened this issue Jul 18, 2023 · 1 comment

Comments

@emrsrb
Copy link

emrsrb commented Jul 18, 2023

Describe the issue:

Does diffusec still function properly even when the new version deviates from the original? For instance, if the old version is 0.6.* and the new version is 0.7.*, will diffusec continue to work? I am faced with two separate projects in this particular situation, and it seems like diffusc have encountered difficulties finding a compatible version that works for both compilations.
Screenshot 2023-07-18 at 3 02 04 PM

Code example to reproduce the issue:

contract v1 0.6.12
contract v2 0.7.12

Version:

1.0.0

Relevant log output:

No response

@webthethird
Copy link
Collaborator

Hmm, I never thought of that issue.

In the generated contract DiffFuzzUpgrades.sol, could you try changing ^0.6.12 to >=0.6.12 and see if that compiles? If so, the fix should be fairly straightforward on my end.

Also, for what it's worth, soon I will be merging a PR which changes the flag for specifying the solc version to use from -v and --version to -V and --solc-version, so that the --version flag behaves the way most people would expect, printing the version of the tool itself. So for your case, when running the tool you would use:
diffusc v1_path v2_path --solc-version 0.6.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants