Run git config instead of reading config file manually
#639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
approved these changes
Sep 4, 2024
GrantBirki
approved these changes
Sep 4, 2024
GrantBirki
reviewed
Sep 4, 2024
| return true if line =~ /mirror\s*=\s*true/ | ||
| end | ||
| false | ||
| capture("git config --get-regexp 'remote\\..+\\.mirror'").each_line.any?(&.==("true")) | ||
| end | ||
|
|
||
| private def origin_url |
There was a problem hiding this comment.
Do you think we can do something similar to origin_url then to fix the problem related to #628?
There was a problem hiding this comment.
Yes, I think this should work similarly.
|
The CI failure due to #640 masked another failure. This patch seems to be broken on Windows.
The reason is that the exit code of |
straight-shoota
added a commit
that referenced
this pull request
Sep 18, 2024
)" This reverts commit e8fe2bd.
This was referenced Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's a good reason to read the config file directly. Going through the CLI is easier and safer.
ref: #638 (comment)