Standardize system codes for file errors

Author: straight-shoota

spec/std/file_spec.cr

@@ -562,6 +562,41 @@ describe "File" do
     end
   end
 
+  long_path = "a" * 1000
+  describe ".info" do
+    it "raises for too long pathname" do
+      expect_raises(File::NotFoundError, /Unable to get file info: '#{long_path}': (File ?name too long|The system cannot find the path specified)/) do
+        File.info(long_path)
+      end
+    end
+
+    it "raises for invalid pathname" do
+      expect_raises(File::NotFoundError, /Unable to get file info: '': (No such file or directory|The system cannot find the path specified)/) do
+        File.info("")
+      end
+    end
+
+    it "raises for invalid pathname" do
+      expect_raises(File::NotFoundError, /Unable to get file info: '<': (No such file or directory|The filename, directory name, or volume label syntax is incorrect)/) do
+        File.info("<")
+      end
+    end
+  end
+
+  describe ".info?" do
+    it "returns nil for too long pathname" do
+      File.info?(long_path).should be_nil
+    end
+
+    it "returns nil for invalid pathname" do
+      File.info?("").should be_nil
+    end
+
+    it "returns nil for invalid pathname" do
+      File.info?("<").should be_nil
+    end
+  end
+
   describe "File::Info" do
     it "gets for this file" do
       info = File.info(datapath("test_file.txt"))

spec/std/process_spec.cr

@@ -68,6 +68,12 @@ describe Process do
       end
     end
 
+    it "raises for long path" do
+      expect_raises(File::NotFoundError, "Error executing process: 'aaaaaaa") do
+        Process.new("a" * 1000)
+      end
+    end
+
     it "accepts nilable string for `chdir` (#13767)" do
       expect_raises(File::NotFoundError, "Error executing process: 'foobarbaz'") do
         Process.new("foobarbaz", chdir: nil.as(String?))

src/crystal/system/file.cr

@@ -71,7 +71,7 @@ module Crystal::System::File
       when Tuple(FileDescriptor::Handle, Bool)
         fd, blocking = result
         return {fd, path, blocking}
-      when Errno::EEXIST, WinError::ERROR_FILE_EXISTS
+      when .in?(File::AlreadyExistsError::OS_ERRORS)
         # retry
       else
         raise ::File::Error.from_os_error("Error creating temporary file", result, file: path)

src/crystal/system/unix/file.cr

@@ -35,7 +35,7 @@ module Crystal::System::File
     if ret == 0
       ::File::Info.new(stat)
     else
-      if Errno.value.in?(Errno::ENOENT, Errno::ENOTDIR)
+      if ::File::NotFoundError::OS_ERRORS.includes?(Errno.value)
         nil
       else
         raise ::File::Error.from_errno("Unable to get file info", file: path)
@@ -129,7 +129,7 @@ module Crystal::System::File
     err = LibC.unlink(path.check_no_null_byte)
     if err != -1
       true
-    elsif !raise_on_missing && Errno.value == Errno::ENOENT
+    elsif !raise_on_missing && ::File::NotFoundError::OS_ERRORS.includes?(Errno.value)
       false
     else
       raise ::File::Error.from_errno("Error deleting file", file: path)
@@ -162,7 +162,7 @@ module Crystal::System::File
     3.times do |iter|
       bytesize = LibC.readlink(path, buf, buf.bytesize)
       if bytesize == -1
-        if Errno.value.in?(Errno::EINVAL, Errno::ENOENT, Errno::ENOTDIR)
+        if ::File::NotFoundError::OS_ERRORS.includes?(Errno.value) || Errno.value == Errno::EINVAL
           yield
         end
 

src/crystal/system/unix/process.cr

@@ -343,7 +343,7 @@ struct Crystal::System::Process
 
   private def self.raise_exception_from_errno(command, errno = Errno.value)
     case errno
-    when Errno::EACCES, Errno::ENOENT, Errno::ENOEXEC
+    when .in?(::File::NotFoundError::OS_ERRORS), .in?(::File::AccessDeniedError::OS_ERRORS), Errno::ENOEXEC
       raise ::File::Error.from_os_error("Error executing process", errno, file: command)
     else
       raise IO::Error.from_os_error("Error executing process: '#{command}'", errno)

src/crystal/system/win32/file.cr

@@ -97,16 +97,9 @@ module Crystal::System::File
     write_blocking(handle, slice, pos: @system_append ? UInt64::MAX : nil)
   end
 
-  NOT_FOUND_ERRORS = {
-    WinError::ERROR_FILE_NOT_FOUND,
-    WinError::ERROR_PATH_NOT_FOUND,
-    WinError::ERROR_INVALID_NAME,
-    WinError::ERROR_DIRECTORY,
-  }
-
   def self.check_not_found_error(message, path)
     error = WinError.value
-    if NOT_FOUND_ERRORS.includes? error
+    if ::File::NotFoundError::OS_ERRORS.includes?(error)
       nil
     else
       raise ::File::Error.from_os_error(message, error, file: path)
@@ -429,7 +422,7 @@ module Crystal::System::File
     info = symlink_info?(path)
     unless info
       {% begin %}
-      if WinError.value.in?({{ NOT_FOUND_ERRORS.splat }}, WinError::ERROR_NOT_A_REPARSE_POINT)
+      if ::File::NotFoundError::OS_ERRORS.includes?(WinError.value) || WinError.value == WinError::ERROR_NOT_A_REPARSE_POINT
         yield
       end
       {% end %}

src/crystal/system/win32/process.cr

@@ -296,8 +296,8 @@ struct Crystal::System::Process
          pointerof(startup_info), pointerof(process_info)
        ) == 0
       error = WinError.value
-      case error.to_errno
-      when Errno::EACCES, Errno::ENOENT, Errno::ENOEXEC
+      case error
+      when .in?(::File::NotFoundError::OS_ERRORS), .in?(::File::AccessDeniedError::OS_ERRORS), WinError::ERROR_BAD_EXE_FORMAT
         raise ::File::Error.from_os_error("Error executing process", error, file: command_args)
       else
         raise IO::Error.from_os_error("Error executing process: '#{command_args}'", error)
@@ -380,7 +380,7 @@ struct Crystal::System::Process
 
   private def self.raise_exception_from_errno(command, errno = Errno.value)
     case errno
-    when Errno::EACCES, Errno::ENOENT
+    when .in?(::File::NotFoundError::OS_ERRORS), .in?(::File::AccessDeniedError::OS_ERRORS)
       raise ::File::Error.from_os_error("Error executing process", errno, file: command)
     else
       raise IO::Error.from_os_error("Error executing process: '#{command}'", errno)

src/file/error.cr

@@ -49,12 +49,21 @@ end
 
 class File::NotFoundError < File::Error
   # :nodoc:
+  # See https://github.com/crystal-lang/crystal/issues/15905#issuecomment-2975820840
   OS_ERRORS = [
+    Errno::ENAMETOOLONG,
     Errno::ENOENT,
+    Errno::ENOTDIR,
+    WinError::ERROR_BAD_NETPATH,
+    WinError::ERROR_BAD_NET_NAME,
+    WinError::ERROR_BAD_PATHNAME,
     WinError::ERROR_DIRECTORY,
     WinError::ERROR_FILE_NOT_FOUND,
+    WinError::ERROR_FILENAME_EXCED_RANGE,
+    WinError::ERROR_INVALID_DRIVE,
     WinError::ERROR_INVALID_NAME,
     WinError::ERROR_PATH_NOT_FOUND,
+    WinError::WSAENAMETOOLONG,
   ]
 end