Fix: interpreter handles self in inlined method with arguments (#16307)

We must handle args first, and then leave self on the stack, instead of handling args last and have them maybe mess with the stack.

Co-authored-by: Julien Portalier <[email protected]>

Author: cyangle

spec/compiler/interpreter/bugs_spec.cr

@@ -210,5 +210,19 @@ describe Crystal::Repl::Interpreter do
         bar.is_a?(Bar)
      CRYSTAL
     end
+
+    it "handles self in inlined method with arguments (#16210)" do
+      interpret(<<-CRYSTAL, prelude: "prelude").should eq(%("hello"))
+        class Foo
+          property x : String?
+
+          def initialize(@x : String? = nil)
+          end
+        end
+
+        foo = Foo.new("hello")
+        foo.x.not_nil!("test")
+      CRYSTAL
+    end
   end
 end

src/compiler/crystal/interpreter/compiler.cr

@@ -1872,6 +1872,9 @@ class Crystal::Repl::Compiler < Crystal::Visitor
     if body.is_a?(Var) && body.name == "self"
       # We also inline calls that simply return "self"
 
+      # We still have to accept the call arguments, but discard their values
+      node.args.each { |arg| discard_value(arg) }
+
       if @wants_value
         if obj
           request_value(obj)
@@ -1885,9 +1888,6 @@ class Crystal::Repl::Compiler < Crystal::Visitor
         end
       end
 
-      # We still have to accept the call arguments, but discard their values
-      node.args.each { |arg| discard_value(arg) }
-
       return false
     end