Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions #47

Open
abebehailu opened this issue Oct 27, 2022 · 8 comments
Open

Questions #47

abebehailu opened this issue Oct 27, 2022 · 8 comments

Comments

@abebehailu
Copy link

abebehailu commented Oct 27, 2022

Hi,

Greate work with this library! I know it is still in the making but I had some questions and input to your roadmap. Does the roadmap include:

  1. Calls to external services to e.g. terminology services. If a feature like that is implemented it would be nice if it also supported authorization OAuth.

  2. Docker support. I had some issues with the setup on a windows environment but eventually got it to work. Would be nice to have a enviroment agnostic setup.

  3. More robust error message when something does not map properly. E.g. using the inspect command with the --aql-path enabled gave me an error message which does not tell me exactly where the issue exists:

    _aql_path = ", " + node.aql_path if aql_path else ""
TypeError: can only concatenate str (not "NoneType") to str
  1. Unicode support. The character å was written down in the composition as \u00e5.
@abebehailu abebehailu changed the title Call to external services Questions Oct 27, 2022
@mdrio
Copy link
Member

mdrio commented Oct 27, 2022

Hi, thanks for the feedback!
So,

  1. sounds interesting, anyway I wonder if that can be done in a general way, allowing user defined functions to be available in the mapping yaml. So basically one can implement his custom function call_remote_service and use it for setting value. I think it can be the driving use case for this feature, so if you have an example at hand it would be nice to use it someway.
  2. ok, I will dockerize the lib soon
  3. I am aware exception handling is very rudimental at this moment. I think it is better to create an issue dedicated for such problem, with some step to reproduce it.
  4. ok, I will check

Stay tuned!

@abebehailu
Copy link
Author

@mdrio Thanks for the quick response.

  1. Interesting approach. An example is where we would like to support e.g. ICD codes in a field and would like to make calls to an external terminology service to map the users choice instead of having all possible ICD codes in the web template.
  2. Ok, great.
  3. Ok, will do that.
  4. Ok, great.

@abebehailu
Copy link
Author

One more question:

  1. Does your roadmap inlcude the development on a UI for creating the mappings? I am thinking of a layer on top of the generated yaml configuration file. Maybe it is out of scope for a low-code tool?

@mdrio
Copy link
Member

mdrio commented Oct 27, 2022

it is something I thought about and I think it could be very a cool feature. At this moment anyway I think it is too early fot a UI, I prefer to wait and see how the library evolves.

@mdrio
Copy link
Member

mdrio commented Nov 2, 2022

You can find docker images at https://hub.docker.com/repository/docker/crs4/flatehr.

@mdrio
Copy link
Member

mdrio commented Nov 3, 2022

Not sure how to reproduce the issue related to unicode , can you give some more information?

@mdrio
Copy link
Member

mdrio commented Nov 3, 2022

New release (see the changelog) introduces some features/fixes you requested. Regarding the terminology server, it can be now implemented as a user defined function. If you have some related example/info of your specific use case, we can try to implement it. If it is feasable to generalize the function, we can then promote it as a builtin function.

@abebehailu
Copy link
Author

Great, I will let you know if I have more input on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants