Merge pull request #262 from kkendzia/fix/remove_invalid_json_tag

lsviben · web-flow · commit f56c8c1cb0cd · 2025-01-08T11:53:04.000+02:00
fix: remove omitempty in invalid json tag combination
diff --git a/apis/release/v1alpha1/types.go b/apis/release/v1alpha1/types.go
@@ -40,7 +40,7 @@ type NamespacedName struct {
 
 // DataKeySelector defines required spec to access a key of a configmap or secret
 type DataKeySelector struct {
-	NamespacedName `json:",inline,omitempty"`
+	NamespacedName `json:",inline"`
 	Key            string `json:"key,omitempty"`
 	Optional       bool   `json:"optional,omitempty"`
 }
diff --git a/apis/release/v1beta1/types.go b/apis/release/v1beta1/types.go
@@ -47,7 +47,7 @@ type NamespacedName struct {
 
 // DataKeySelector defines required spec to access a key of a configmap or secret
 type DataKeySelector struct {
-	NamespacedName `json:",inline,omitempty"`
+	NamespacedName `json:",inline"`
 	Key            string `json:"key,omitempty"`
 	Optional       bool   `json:"optional,omitempty"`
 }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ type NamespacedName struct {`
`40`	`40`
`41`	`41`	`// DataKeySelector defines required spec to access a key of a configmap or secret`
`42`	`42`	`type DataKeySelector struct {`
`43`		- NamespacedName `json:",inline,omitempty"`
	`43`	+ NamespacedName `json:",inline"`
`44`	`44`	Key string `json:"key,omitempty"`
`45`	`45`	Optional bool `json:"optional,omitempty"`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ type NamespacedName struct {`
`47`	`47`
`48`	`48`	`// DataKeySelector defines required spec to access a key of a configmap or secret`
`49`	`49`	`type DataKeySelector struct {`
`50`		- NamespacedName `json:",inline,omitempty"`
	`50`	+ NamespacedName `json:",inline"`
`51`	`51`	Key string `json:"key,omitempty"`
`52`	`52`	Optional bool `json:"optional,omitempty"`
`53`	`53`	`}`