feat: add kafka topic support #16
Conversation
sschne
force-pushed
the
f/kafka-topic-support
branch
from
5ea258d
to
c789cfa
Compare
Signed-off-by: Simon Schneider <[email protected]>
sschne
force-pushed
the
f/kafka-topic-support
branch
from
c789cfa
to
627c82d
Compare
|
@jaylevin any chance to get this merged soon? |
| } | ||
|
|
||
| // Allows us to reference managedResource ID via spec.forProvider.principal.idSelector | ||
| r.References["principal"] = config.Reference{ |
There was a problem hiding this comment.
Was this a leftover copy and paste? I don't see principal listed as a field on the terraform docs for this resource, ref: https://registry.terraform.io/providers/confluentinc/confluent/1.55.0/docs/resources/confluent_kafka_topic
There was a problem hiding this comment.
Was this a leftover copy and paste? I don't see
principallisted as a field on the terraform docs for this resource, ref: https://registry.terraform.io/providers/confluentinc/confluent/1.55.0/docs/resources/confluent_kafka_topic
You're absolutely right. Somehow i mixed that up with the credentials parameters, but this is obviously something different. Sorry for that.
|
I ported your changes over to #17 and was able to successfully build and test the changes 👍 |
This adds support for managing Kafka topics.
Fixes #15
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally with crossplane 1.16.0