Rule 1034: AddedRequiredProperty does not support requests with oneOf syntax.

[kristofferpagels]

Hi,

We have an api generated by NSwag and it is using oneOf to define requests, but that doesn't seem to be recognized by openapi-comparator.

Example:

"requestBody": {
          "x-name": "request",
          "content": {
            "application/json": {
              "schema": {
                "nullable": false,
                "oneOf": [
                  {
                    "$ref": "#/components/schemas/TicketPostRequest"
                  }
                ]
              }
            }
          }

vs without oneOf (manually created)

"requestBody": {
          "x-name": "request",
          "content": {
            "application/json": {
              "schema": {
                 "$ref": "#/components/schemas/TicketPostRequest"
              }
            }
          },
          "required": true,
          "x-position": 1
        }

I have attached four json documents

• old3.json
• new3.json
• old3a.json
• new3a.json

When comparing old3.json and new3.json (which is using oneOf and have introduced a required property in a request object) we get the following rule difference for 1034:

Rule	Error	JsonPath
1034	The new version has new required property 'testNullableProperty' that was not found in the old version.	#/components/schemas/TicketPostRequest

If we change to directly referencing the schema (i.e. not using oneOf) and compare old3a.json with new31.json we get a different and more precise rule difference:

Rule	Error	JsonPath
1034	The new version has new required property 'testNullableProperty' that was not found in the old version.	#/paths/~1api~1public~1form/post/requestBody/content/application~1json/schema

Would it be possible to get support for oneOf syntax as this is what NSwag generates?

Regards
/Kristoffer