Build(deps-dev): bump rubocop from 1.55.1 to 1.56.0 (#3441)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin ! <[email protected]>

Author: dependabot[bot]

Gemfile.lock

@@ -88,6 +88,7 @@ GEM
       aws-sigv4 (~> 1.6)
     aws-sigv4 (1.6.0)
       aws-eventstream (~> 1, >= 1.0.2)
+    base64 (0.1.1)
     bcrypt (3.1.19)
     better_html (2.0.2)
       actionview (>= 6.0)
@@ -368,7 +369,8 @@ GEM
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
     rspec-support (3.12.1)
-    rubocop (1.55.1)
+    rubocop (1.56.0)
+      base64 (~> 0.1.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)

app/controllers/admin/episodes_controller.rb

@@ -52,7 +52,7 @@ def set_podcasts
 
     def set_episode
       @episode = Episode.find(params[:id])
-      return redirect_to %i[admin podcasts] if @episode.blank?
+      redirect_to %i[admin podcasts] if @episode.blank?
     end
 
     def episode_params

app/controllers/admin/users_controller.rb

@@ -55,7 +55,7 @@ def user_params
     end
 
     def authorize_admin_role
-      return redirect_to [:admin] unless Current.user.can_admin_users?
+      redirect_to [:admin] unless Current.user.can_admin_users?
     end
   end
 end

app/controllers/application_controller.rb

@@ -75,7 +75,7 @@ def check_for_redirection
 
   # TODO: move to rack middleware
   def strip_file_extension
-    return redirect_to request.path.sub('.html', '') if request.path.include?('.html')
+    redirect_to request.path.sub('.html', '') if request.path.include?('.html')
   end
 
   # TODO: move to meta helper

app/controllers/books_controller.rb

@@ -51,6 +51,6 @@ def into_libraries
 
   def set_book
     @book = Book.find_by(slug: params[:slug])
-    return redirect_to [:books] if @book.blank?
+    redirect_to [:books] if @book.blank?
   end
 end

app/controllers/categories_controller.rb

@@ -29,7 +29,7 @@ def feed
   def set_slug
     @slug = params[:slug].dasherize
 
-    return redirect_to category_path(@slug) if @slug != params[:slug]
+    redirect_to category_path(@slug) if @slug != params[:slug]
   end
 
   def set_category
@@ -46,7 +46,7 @@ def set_title
   def set_articles
     @articles = @category.articles.for_index(**filters).page(params[:page]).per(25)
 
-    return redirect_to root_path if @articles.blank?
+    redirect_to root_path if @articles.blank?
   end
 
   def filters

app/controllers/definitions_controller.rb

@@ -43,6 +43,6 @@ def set_book
 
   def set_definition
     @definition = Definition.find_by(slug: params[:slug])
-    return redirect_to [:definitions] if @definition.blank?
+    redirect_to [:definitions] if @definition.blank?
   end
 end

app/controllers/episodes_controller.rb

@@ -30,7 +30,7 @@ def set_episode
     if request.path.starts_with? '/draft'
       @episode = Episode.find_by(draft_code: params[:draft_code])
 
-      return redirect_to(@episode.path) if @episode&.published?
+      redirect_to(@episode.path) if @episode&.published?
     else
       @episode = Episode.live.find_by(podcast_id: @podcast, episode_number: params[:episode_number])
       return @episode if @episode.present?

app/controllers/languages_controller.rb

@@ -28,6 +28,6 @@ def canonical_locale
   def set_articles
     abbreviation = canonical_locale&.lang_code
     @articles = Article.live.published.where(locale: abbreviation).page(params[:page]).per(25)
-    return redirect_to languages_path if @articles.empty?
+    redirect_to languages_path if @articles.empty?
   end
 end

app/controllers/pages_controller.rb

@@ -75,7 +75,7 @@ def set_page
   def page_redirects
     return render file: Rails.public_path.join('404.html'), status: :not_found if @page.nil?
 
-    return redirect_to @page.path if @page.published? && params[:draft_code].present?
+    redirect_to @page.path if @page.published? && params[:draft_code].present?
   end
 
   def set_html_id