For CI, deploy to Arbitrum Sepolia instead of Base Sepolia #89

jplodge-pro · 2024-08-07T09:33:30Z

Deploy to Arbitrum Sepolia testnet instead of Base Sepolia, for CI deployments.

Done

Changed deploy:ci build script to invoke make deploy-arbitrumSepolia
Added Arbitrum Sepolia specific environment variables to the GitHub Action.
Also updated the GitHub testnet Environment with same.
Also updated the foundry.toml with same.
Renamed the Arbitrum Sepolia specific make target to use the Network Alias
Tweaked the deploy and verify commands in make to use the Build Scripts to assure a consistent state
Added a means to use alternative Deployer Authentication, if needed.
- For example, instead of a Private Key, we could use a cast wallet Account and Password, like so:
  DEPLOYER_AUTHENTICATION="--account DEVOPS_DEPLOYER --password xyz"
Updated testnet.toml to reference the correct Chain Id.
Pinned GitHub Action Foundry version (@lucasia)
Changed to use Blockscout as the Verifier (@lucasia)

Resolves #88

Removed the `db-export` from `deploy:ci` as it is a post-deploy operation and is invoked from the makefile. Removed `tsc` from `gen-types` and added it to `build` as a more natural fit.

Added `yarn` `clean` and `build` to the generic `deploy` target so all deployments are clean.

Tweaked foundry variables to match those added to GitHub Environment. Added the required variable mapping to GitHub Action Tweaked the `Makefile` to `clean` and `build` before deploy and resume. Added the DEPLOY_SCRIPT variable to the Makefile Added the DEPLOYER_AUTHENTICATION variable to the Makefile, defaulting to the PK parameter and env variable. But this simplifies deploying to testnet from local.

lucasia

the deployment to arbitrumSepolia from the branch works fine using the below on my machine at lest. please confirm the versions of forge and forge-std you are using.

forge nightly (foundryup) forge 0.2.0 (4351742 2024-08-07T00:24:31.137910000Z)

foundryup
forge --version

git submodule status
07263d193d621c4b2b0ce8b4d54af58f6957d97d forge-std (v1.9.1)
dbb6104ce834628e473d2173bbc9d47f81a9eec3 openzeppelin-contracts (v5.0.0-12-gdbb6104c)

packages/contracts/Makefile

packages/contracts/package.json

jplodge-pro · 2024-08-08T05:11:47Z

Thanks for the review, @lucasia

the deployment to arbitrumSepolia from the branch works fine using the below on my machine at lest. please confirm the versions of forge and forge-std you are using.

forge nightly (foundryup) forge 0.2.0 (4351742 2024-08-07T00:24:31.137910000Z)

foundryup

forge --version

git submodule status 07263d193d621c4b2b0ce8b4d54af58f6957d97d forge-std (v1.9.1) dbb6104ce834628e473d2173bbc9d47f81a9eec3 openzeppelin-contracts (v5.0.0-12-gdbb6104c)

I foolishly ran foundryup before checking my version, so I don't know my previous version.
Now, however, my versions are as follows:

forge 0.2.0 (7f0f5b4 2024-08-08T00:19:27.650028841Z)

 07263d193d621c4b2b0ce8b4d54af58f6957d97d lib/forge-std (v1.9.1)
 dbb6104ce834628e473d2173bbc9d47f81a9eec3 lib/openzeppelin-contracts (v5.0.0-12-gdbb6104c)

I will re-test the deployment.

UPDATE

The problem was that I did not have ETHERSCAN_API_KEY AND ARBITRUM_SEPOLIA_ETHERSCAN_API_KEY set in the .env file at the same time.
With that setting, the deploy/verify works correctly (db-export still fails, as that supabase instance is mothballed).

…ation. Added comments explaining some deployment discoveries.

Removed the Base Sepolia key.

…can error issues

openzeppelin-code · 2024-08-13T12:02:34Z

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia

Generated at commit: dce2a85d1f69710b1156314b13fef4b300b41160

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	0 0 0 4 15 19
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

…ecode match.

Removed the separation of deployment and verification of contracts. Removed the shell script that enabled the separation. Directly reference the Verifier URL in the script command.

lucasia · 2024-12-03T13:31:05Z

Closing - de-prioritized.

jplodge-pro added 6 commits August 7, 2024 12:51

Changed deploy:ci to deploy to Arbitrum Sepolia

48e1b1c

Removed the `db-export` from `deploy:ci` as it is a post-deploy operation and is invoked from the makefile. Removed `tsc` from `gen-types` and added it to `build` as a more natural fit.

Only formatted.

2863b10

Changed the Network Id to Arbitrum Sepolia.

63a105d

Renamed deploy-arbSepolia to the full-name deploy-arbitrumSepolia

aef04a0

Added `yarn` `clean` and `build` to the generic `deploy` target so all deployments are clean.

Upgraded solhint to 5.0.3 due to error running it.

f4d09ed

jplodge-pro requested review from lucasia and ChaiSomsri96 August 7, 2024 09:34

jplodge-pro marked this pull request as ready for review August 7, 2024 10:36

jplodge-pro requested a review from Krishnakumarskr August 7, 2024 10:37

lucasia requested changes Aug 7, 2024

View reviewed changes

packages/contracts/Makefile Outdated Show resolved Hide resolved

packages/contracts/Makefile Outdated Show resolved Hide resolved

packages/contracts/package.json Show resolved Hide resolved

packages/contracts/package.json Show resolved Hide resolved

Added prefixed '@' to make commands to avoid outputting secret inform…

23acada

…ation. Added comments explaining some deployment discoveries.

jplodge-pro requested a review from lucasia August 8, 2024 06:46

Enabled Github Action for this branch.

1af018f

jplodge-pro temporarily deployed to local August 8, 2024 11:34 — with GitHub Actions Inactive

jplodge-pro had a problem deploying to testnet August 8, 2024 11:35 — with GitHub Actions Failure

Added the ETHERSCAN_API_KEY explicitly.

e9d39f1

Removed the Base Sepolia key.

jplodge-pro temporarily deployed to local August 8, 2024 11:51 — with GitHub Actions Inactive

jplodge-pro temporarily deployed to testnet August 8, 2024 11:52 — with GitHub Actions Inactive

jplodge-pro added 2 commits August 8, 2024 20:00

exporter.js now fails as a process, on Error.

7596b20

Upgraded to actions@checkoutv4.

c0830e2

jplodge-pro temporarily deployed to local August 8, 2024 12:01 — with GitHub Actions Inactive

jplodge-pro had a problem deploying to testnet August 8, 2024 12:02 — with GitHub Actions Failure

Remove the branch from the GitHub Action triggers.

6aeb841

jplodge-pro temporarily deployed to local August 8, 2024 12:37 — with GitHub Actions Inactive

jplodge-pro temporarily deployed to testnet August 8, 2024 12:38 — with GitHub Actions Inactive

Specify Foundry version in Github actions. Later versions have Ethers…

d267f53

…can error issues

lucasia temporarily deployed to local August 8, 2024 12:51 — with GitHub Actions Inactive

lucasia temporarily deployed to testnet August 8, 2024 12:52 — with GitHub Actions Inactive

jplodge-pro temporarily deployed to local August 13, 2024 12:00 — with GitHub Actions Inactive

jplodge-pro had a problem deploying to testnet August 13, 2024 12:01 — with GitHub Actions Failure

jplodge-pro added 2 commits August 13, 2024 20:39

Make them all more valid.

ec7bc67

Change to nightly foundry.

c8405de

jplodge-pro temporarily deployed to local August 13, 2024 12:48 — with GitHub Actions Inactive

jplodge-pro had a problem deploying to testnet August 13, 2024 12:49 — with GitHub Actions Failure

Krishnakumarskr and others added 15 commits August 14, 2024 14:01

fix: F-2024-4399

d220958

fix: F-2024-4400 - only for update functions

8c14010

fix: F-2024-4403

8fdc451

fixed lint warning for immutable variables

64e21b3

fix: F-2024-4414

b60f389

fix: F-2024-4416 only for collateral percentage

570cddb

fix: F-2024-4396

fe1179d

fix: F-2024-4398

3b3b69f

fix: F-2024-4400

57c2843

rename collateral to upside

be52215

pr comment fix

cebf163

fix: F-2024-4414, on vault factory

da7574f

Update CBL Readme to add locking to receive Governance Token ()

ec48370

Alter the code so that Arbiscan does not verify on fuzzy deployed byt…

e9f3d43

…ecode match.

Removed the options for Arbitrum Sepolia.

1f185f2

Removed the separation of deployment and verification of contracts. Removed the shell script that enabled the separation. Directly reference the Verifier URL in the script command.

jplodge-pro temporarily deployed to local August 14, 2024 06:28 — with GitHub Actions Inactive

jplodge-pro temporarily deployed to testnet August 14, 2024 06:29 — with GitHub Actions Inactive

jplodge-pro added 3 commits August 14, 2024 15:07

Reverted all deployed contract changs.

9691ef2

Restored the use of pinned foundry version in CI/Testnet deployment.

eb0512d

Remove the --verifier-url from the makefile.

dce2a85

lucasia closed this Dec 3, 2024

lucasia deleted the deploy-ci-arb-sepolia branch December 3, 2024 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia #89

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia #89

jplodge-pro commented Aug 7, 2024 •

edited

Loading

lucasia left a comment

jplodge-pro commented Aug 8, 2024 •

edited

Loading

openzeppelin-code bot commented Aug 13, 2024 •

edited

Loading

lucasia commented Dec 3, 2024

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia #89

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia #89

Conversation

jplodge-pro commented Aug 7, 2024 • edited Loading

Done

lucasia left a comment

Choose a reason for hiding this comment

jplodge-pro commented Aug 8, 2024 • edited Loading

UPDATE

openzeppelin-code bot commented Aug 13, 2024 • edited Loading

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia

🚨 Report Summary

lucasia commented Dec 3, 2024

jplodge-pro commented Aug 7, 2024 •

edited

Loading

jplodge-pro commented Aug 8, 2024 •

edited

Loading

openzeppelin-code bot commented Aug 13, 2024 •

edited

Loading