Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]High Severity Vulnerabilities in Older react-scripts and node-sass and Nested Dependencies #32

Closed
mekkim opened this issue Mar 21, 2022 · 2 comments

Comments

@mekkim
Copy link

mekkim commented Mar 21, 2022

Version
Latest

Reproduction link
https://github.com/mekkim/donatemask

Operating System
All

Device
All

Browser & Version
All

Steps to reproduce
Run npm audit against latest branch.

What is expected?
No vulnerabilities in dependencies

What is actually happening?
38 vulnerabilities (20 moderate, 18 high) in dependencies.
npm audit fix advises that upgrades required to address vulnerabilities are breaking.

Solution
Dependencies and any resulting breaking feature changes should be resolved
react-scripts to version 5.0.0+
node-sass to version 7.0.1+

Additional comments
npm audit log: https://pastes.io/tr6m6umkip

@github-actions
Copy link

@mekkim this issue was automatically closed because it did not follow our rules:

IMPORTANT: Please use the following link to create a new issue:

https://www.creative-tim.com/new-issue/argon-design-system-react

**If your issue was not created using the app above, it will be closed immediately.**



Love Creative Tim? Do you need Angular, React, Vuejs or HTML? You can visit:
👉  https://www.creative-tim.com/bundles
👉  https://www.creative-tim.com


@mekkim
Copy link
Author

mekkim commented Mar 21, 2022

Can be fixed by changing package.json to use latest versions of node-sass and react-scripts (though unsure if that breaks anything as latest is a breaking change relative to currently listed versions--testing required!)

"node-sass": "latest",
"react-scripts": "latest",

plus adding the following at the end for the nested dependencies of glob-parent and nth-check. Same caveat re: breaking potential:

"overrides": {
	   "glob-parent": "latest",
	   "nth-check": "latest"
   }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant