Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't load icons #15

Closed
ghost opened this issue May 24, 2020 · 10 comments
Closed

Can't load icons #15

ghost opened this issue May 24, 2020 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented May 24, 2020

Version

1.1.0

Reproduction link

https://github.com/sc4224/typescript-graphql

Operating System

Mac OSX Catalina

Device

iMac

Browser & Version

Chrome 83.0.4103.61

Steps to reproduce

  1. git clone the repo
  2. execute yarn
  3. execute yarn dev
  4. Go to http://localhost:3000
  5. Imported the scss and css files as instructed
    import 'argon-design-system-react/src/assets/vendor/nucleo/css/nucleo.css';
    import 'argon-design-system-react/src/assets/vendor/font-awesome/css/font-awesome.min.css';
    import 'argon-design-system-react/src/assets/scss/argon-design-system-react.scss';
  6. Open Sans font is loading, but Icons on the Input field are not loading.

What is expected?

Icons to load for valid and invalid Input fields

What is actually happening?

Icons are not loading, square box placeholder is showing up where the icon should be
Screenshot 2020-05-24 at 7 10 37 PM


Solution

Additional comments

@ghost ghost changed the title Can't load fonts Can't load icons May 24, 2020
@einazare
Copy link
Contributor

Hello there, @sc4224

Please check our live docs here: https://demos.creative-tim.com/argon-design-system-react/#/documentation/quick-start

Best,
Manu

@ghost
Copy link
Author

ghost commented May 26, 2020

Hey @einazare I've already checked the docs and followed the instructions as stated where I import the css files. It does not work though, what am I doing wrong?

@einazare
Copy link
Contributor

Hello again, @sc4224 ,

Have you also added the fonts inside the .html file?

Best,
Manu

@ghost
Copy link
Author

ghost commented May 26, 2020

@einazare yes I've tried that, included the font in the html. Still does not work

@ghost
Copy link
Author

ghost commented May 26, 2020

@einazare have you tried to work this with the nextjs framework?

@einazare
Copy link
Contributor

Hello again, @sc4224 ,

Unfortunately, no, we haven't tried it with NextJS, from what we know, NextJS has other ways of importing CSS/SCSS, that might be the cause.
We will investigate this and come back with a response.
In the meantime, any insights are welcomed.

Best,
Manu

@ghost
Copy link
Author

ghost commented May 27, 2020

@einazare the things i've tried so far was to install url loader and configure webpack through next.config.js. It does not seem to do the job for me. CSS and SCSS imports were done correctly through libraries next-sass, next-css and next-fonts. As you can see in the picture the styling was included, it was just the icon could not load.

@einazare einazare added the help wanted Extra attention is needed label May 28, 2020
@einazare
Copy link
Contributor

Hello again, @sc4224 ,

I am sorry, but at the moment, we've only worked with NextJS and our material products: https://www.creative-tim.com/templates/nextjs
Also, if you check our unaltered products: https://www.creative-tim.com/product/argon-design-system-react
You will see that it works without any issues.
We are sorry, but we cannot help you further.

I will leave this issue open, and maybe someone from our community will come to your help.

Best,
Manu

@yassinetb
Copy link

yassinetb commented Feb 6, 2021

Fixed the issue by downgrading the react-script version to 3.4.4. Solution found from here:
facebook/create-react-app#9992

@einazare
Copy link
Contributor

einazare commented Feb 8, 2021

Hello there guys,

I think for font, you could use the following: https://www.npmjs.com/package/next-fonts

Best,
Manu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants