Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scss var in compiled css #10

Closed
Dolu89 opened this issue Mar 28, 2020 · 2 comments
Closed

scss var in compiled css #10

Dolu89 opened this issue Mar 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Dolu89
Copy link

Dolu89 commented Mar 28, 2020

Hello,

I have a problem on npm run build because there is some var in compiled css
Did I miss something ?
Anyway, I used sass to compile scss files.

width: calc(100% - $icon-size-xl - 1); }

Thanks for this awesome design anyway!

@einazare
Copy link
Contributor

Hello there, @Dolu89 ,

I am not sure why this happens.
I've tried to fix it, but without any prevail, any guidance will be much appreciated.

Best,
Manu

@einazare einazare added the bug Something isn't working label Mar 30, 2020
@ihatem
Copy link

ihatem commented May 27, 2020

I had the same issue, looks like argon-design-system-react.scss file is pointing to the wrong paths.

I update the paths manually, it works but it's not viable with node_modules updates.

Here's the scss file updated:

 // Bootstrap Functions
-@import "../../../node_modules/bootstrap/scss/functions";
+@import "bootstrap/scss/_functions.scss";

 // Theme Variables
-@import "argon-design-system/variables";
+@import "./argon-design-system/variables";

 // Bootstrap Core
-@import "../../../node_modules/bootstrap/scss/bootstrap";
+@import "bootstrap/scss/bootstrap";

 // Theme Core
-@import "argon-design-system/theme";
+@import "./argon-design-system/theme";

 // React Differences
-@import "react/react-differences";
+@import "./react/react-differences";

PR is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants